rustdoc: clean up JS #110030
Merged
rustdoc: clean up JS #110030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
* Stop checking `func` in `onEach`. It's always hard-coded right at the call site, so there's no point. * Use the ternary operator in a few spots where it makes sense. * No point in making `onEach` store `arr.length` in a variable if it's only used once anyway.
notriddle
force-pushed
the
notriddle/clean-up-js
branch
from
c8121f9 to
815f5bb
Compare
notriddle
changed the title
GuillaumeGomez
approved these changes
Apr 7, 2023
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Apr 8, 2023
…=GuillaumeGomez rustdoc: clean up JS * Stop checking `func` in `onEach`. It's always hard-coded right at the call site, so there's no point. * Use the ternary operator in a few spots where it makes sense. * No point in making `onEach` store `arr.length` in a variable if it's only used once anyway.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2023
Rollup of 5 pull requests Successful merges: - rust-lang#110030 (rustdoc: clean up JS) - rust-lang#110037 (rustdoc: add test and bug fix for theme defaults) - rust-lang#110065 (Fix wrong type in docs: i16 -> u16) - rust-lang#110068 (Temporarily remove myself from reviewers list) - rust-lang#110075 (Fix a typo in `config.example.toml`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funcinonEach. It's always hard-coded right at the call site, so there's no point.onEachstorearr.lengthin a variable if it's only used once anyway.