Skip to content

Conversation

est31
Copy link
Member

@est31 est31 commented Mar 16, 2023

I went over the cases where sort_by is used and in these two, one can use sort_by_key instead.

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2023

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2023
I went over the cases where sort_by is used and in these two,
one can use sort_by_key instead.
@Noratrieb
Copy link
Member

r? Nilstrieb
r=me when CI is green
@bors delegate+

@bors
Copy link
Collaborator

bors commented Mar 16, 2023

✌️ @est31 can now approve this pull request

@Noratrieb
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 16, 2023

📌 Commit a8839c3 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2023
@Noratrieb
Copy link
Member

@bors rollup=always

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 16, 2023
Use sort_by_key instead of sort_by

I went over the cases where sort_by is used and in these two, one can use sort_by_key instead.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
Use sort_by_key instead of sort_by

I went over the cases where sort_by is used and in these two, one can use sort_by_key instead.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2023
Use sort_by_key instead of sort_by

I went over the cases where sort_by is used and in these two, one can use sort_by_key instead.
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#108958 (Remove box expressions from HIR)
 - rust-lang#109044 (Prevent stable `libtest` from supporting `-Zunstable-options`)
 - rust-lang#109155 (Fix riscv64 fuchsia LLVM target name)
 - rust-lang#109156 (Fix linker detection for clang with prefix)
 - rust-lang#109181 (inherit_overflow: adapt pattern to also work with v0 mangling)
 - rust-lang#109198 (Install projection from RPITIT to default trait method opaque correctly)
 - rust-lang#109215 (Use sort_by_key instead of sort_by)
 - rust-lang#109229 (Fix invalid markdown link references)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a530f72 into rust-lang:master Mar 17, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants