Bless uitest source annotations #109080
Closed
Bless uitest source annotations #109080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
The whole purpose of these annotations is that you take care with them and make a decision on every single one, especially if the lines change or the formatting changes. I do see that when you do changes to main error messages that they affect a lot of ui tests, but I don't think making blessing the default is a good idea. |
|
What do you think about putting this behind a new flag like |
|
My problem is not with how complicated it is to do, but with the fact that it is doable at all. I do not think we should pursue this. We already bless stderr files, if we blessed the annotations we could also just not have the annotations and only look at the stderr output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--blessis set, automatically rewrite the test file with the found annotations. I'm not sure if the line length numbers here are great.I'm also not sure what the best way to approach re-blessing stderr files is (in case line numbers were changed with the new annotations)