Skip to content

Conversation

raoulstrackx
Copy link
Contributor

The LVI tests for the x86_64-fortanix-unknown-sgx target have gotten out of sync. LVI is still mitigated correctly, but the LVI tests need minor modifications. Other (non LVI-related) tests fail when the target applies LVI mitigations as they assume the generated code contains forbidden instructions such as retq. These tests are ignored for the sgx environment.

cc: @jethrogb

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2023
@raoulstrackx raoulstrackx force-pushed the raoul/sync_lvi_patches branch from c6527fd to d8ca1ba Compare March 10, 2023 16:16
@raoulstrackx raoulstrackx force-pushed the raoul/sync_lvi_patches branch from d8ca1ba to d69ebf7 Compare March 10, 2023 16:55
@Mark-Simulacrum
Copy link
Member

r? cuviper since I think you last reviewed these

@rustbot rustbot assigned cuviper and unassigned Mark-Simulacrum Mar 18, 2023
@cuviper
Copy link
Member

cuviper commented Mar 23, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 23, 2023

📌 Commit d69ebf7 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108629 (rustdoc: add support for type filters in arguments and generics)
 - rust-lang#108924 (panic_immediate_abort requires abort as a panic strategy)
 - rust-lang#108961 (Refine error spans for const args in hir typeck)
 - rust-lang#108986 (sync LVI tests)
 - rust-lang#109142 (Add block-based mutex unlocking example)
 - rust-lang#109368 (fix typo in the creation of OpenOption for RustyHermit)
 - rust-lang#109493 (Return nested obligations from canonical response var unification)
 - rust-lang#109515 (Add AixLinker to support linking on AIX)
 - rust-lang#109536 (resolve: Rename some cstore methods to match queries and add comments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cfd8105 into rust-lang:master Mar 24, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 24, 2023
@workingjubilee workingjubilee added the O-SGX Target: SGX label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-SGX Target: SGX S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants