- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Fix more benchmark test with black_box #108291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           r? @scottmcm (rustbot has picked a reviewer for you, use r? to override)  | 
    
| 
           Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any  Examples of  
  | 
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
276f61e    to
    f3ff183      
    Compare
  
    | 
           These commits modify the  If this was intentional then you can ignore this comment.  | 
    
f3ff183    to
    62cfd8a      
    Compare
  
    | 
           Do you have before/after numbers to see if they have any effect? you can use   | 
    
          
 yes, it has effect, for example: gh-chenyukang@dev-desktop-us-2:~/2rust$ cargo benchcmp i1.perf i2.perf
 name                                      i1.perf ns/iter  i2.perf ns/iter  diff ns/iter  diff %  speedup
 num::dec2flt::bench_0                     50               62                         12  24.00%   x 0.81
 num::dec2flt::bench_1e150                 51               61                         10  19.61%   x 0.84
 num::dec2flt::bench_42                    36               47                         11  30.56%   x 0.77
 num::dec2flt::bench_huge_int              190              196                         6   3.16%   x 0.97
 num::dec2flt::bench_long_decimal_and_exp  206              212                         6   2.91%   x 0.97
 num::dec2flt::bench_max                   74               84                         10  13.51%   x 0.88
 num::dec2flt::bench_min_normal            75               85                         10  13.33%   x 0.88
 num::dec2flt::bench_min_subnormal         52               61                          9  17.31%   x 0.85
 num::dec2flt::bench_pi_long               168              172                         4   2.38%   x 0.98
 num::dec2flt::bench_pi_short              62               77                         15  24.19%   x 0.81
 num::dec2flt::bench_short_decimal         56               71                         15  26.79%   x 0.79
 num::flt2dec::bench_big_shortest          213              213                         0   0.00%   x 1.00
 num::flt2dec::bench_small_shortest        152              153                         1   0.66%   x 0.99 | 
    
| 
           r? library  | 
    
| 
           Failed to set assignee to  
  | 
    
| 
           r? libs  | 
    
| 
           This looks much better, thank you! r? @workingjubilee  | 
    
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108291 (Fix more benchmark test with black_box) - rust-lang#108356 (improve doc test for UnsafeCell::raw_get) - rust-lang#110049 (Don't claim `LocalKey::with` prevents a reference to be sent across threads) - rust-lang#111525 (Stop checking for the absence of something that doesn't exist) - rust-lang#111538 (Make sure the build.rustc version is either the same or 1 apart) - rust-lang#111578 (Move expansion of query macros in rustc_middle to rustc_middle::query) - rust-lang#111584 (Number lexing tweaks) - rust-lang#111587 (Custom MIR: Support `Rvalue::CopyForDeref`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Follow up fix for #107590