Skip to content

remove FIXME that doesn't require fixing #108259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2023
Merged

remove FIXME that doesn't require fixing #108259

merged 1 commit into from
Feb 20, 2023

Conversation

fee1-dead
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 20, 2023
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Feb 20, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 20, 2023

📌 Commit be599f3 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 20, 2023
@matthiaskrgr
Rollup merge of rust-lang#108259 - fee1-dead-contrib:fixme-2, r=TaKO8Ki
30a7793 
remove FIXME that doesn't require fixing
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 20, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 20, 2023
@bors
Auto merge of rust-lang#108268 - matthiaskrgr:rollup-4tdvnx6, r=matth…
8973049 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#108124 (Document that CStr::as_ptr returns a type alias)
 - rust-lang#108171 (Improve building compiler artifacts output)
 - rust-lang#108200 (Use restricted Damerau-Levenshtein distance for diagnostics)
 - rust-lang#108259 (remove FIXME that doesn't require fixing)
 - rust-lang#108265 ("`const` generic" -> "const parameter")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 133afeb into rust-lang:master Feb 20, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 20, 2023
@fee1-dead fee1-dead deleted the fixme-2 branch February 22, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fee1-dead @rustbot @TaKO8Ki @bors