Skip to content

Download rustfmt regardless of rustc being set in config.toml #108212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2023
Merged

Download rustfmt regardless of rustc being set in config.toml #108212

merged 1 commit into from
Feb 19, 2023
+0 −9

Conversation

KittyBorgX
Copy link
Member

@KittyBorgX KittyBorgX commented Feb 18, 2023 •
edited
Loading

Fixes #81155

cc : #108210 for exact error details

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 18, 2023
jyn514
jyn514 suggested changes Feb 18, 2023
View reviewed changes
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2023
@KittyBorgX
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2023
@jyn514
Copy link
Member

jyn514 commented Feb 19, 2023

r? jyn514

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 19, 2023

📌 Commit cd3d4fc has been approved by jyn514

It is now in the queue for this repository.

@rustbot rustbot assigned jyn514 and unassigned Mark-Simulacrum Feb 19, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 19, 2023
@bors
Auto merge of rust-lang#108237 - GuillaumeGomez:rollup-olxq5dt, r=Gui…
dc89a80 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#107766 (Fix json reexports of different items with same name)
 - rust-lang#108129 (Correctly handle links starting with whitespace)
 - rust-lang#108188 (Change src/etc/vscode_settings.json to always treat ./library as the sysroot source)
 - rust-lang#108203 (Fix RPITITs in default trait methods (by assuming projection predicates in param-env))
 - rust-lang#108212 (Download rustfmt regardless of rustc being set in config.toml)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 24d907a into rust-lang:master Feb 19, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jyn514 jyn514 jyn514 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

./x.py fmt uses incorrect rustfmt with download-ci-llvm=true and custom rustc (not stage0/beta)
5 participants
@KittyBorgX @rustbot @jyn514 @bors @Mark-Simulacrum