Skip to content

Conversation

pnkfelix
Copy link
Contributor

@pnkfelix pnkfelix commented Feb 2, 2023

ArArchiveBuilder doesn't support reading thin archives, causing a regression.

This is a backport of the third of three commits from PR #107360 (the other two commits are only relevant to 1.68-beta and nightly, not 1.67-stable).

ArArchiveBuilder doesn't support reading thin archives, causing a
regression.
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 2, 2023
@pnkfelix pnkfelix changed the title Revert back to LlvmArchiveBuilder on all platforms [1.67-stable backport] Revert back to LlvmArchiveBuilder on all platforms Feb 2, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
  CACHE_DOMAIN: ci-caches.rust-lang.org
  IMAGE: mingw-check
##[endgroup]
fatal: unknown commit origin/master
fatal: unknown commit origin/beta
All commits in `HEAD` are present in `master`
All commits in `HEAD` are present in `beta`
src/ci/scripts/verify-stable-version-number.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: mingw-check

@pnkfelix
Copy link
Contributor Author

pnkfelix commented Feb 6, 2023

hmm i guess I should figure out how to fix this

@cuviper
Copy link
Member

cuviper commented Feb 6, 2023

If it's just the problem with the version check, I can handle that when I pull together a complete release PR.

@bors bors merged commit 3416a0f into rust-lang:stable Feb 7, 2023
@bors
Copy link
Collaborator

bors commented Feb 7, 2023

☔ The latest upstream changes (presumably #107743) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss ehuss added this to the 1.67.0 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants