Skip to content

Conversation

anden3
Copy link
Contributor

@anden3 anden3 commented Jan 14, 2023

Was asked to do it by @Nilstrieb

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 14, 2023
@anden3
Copy link
Contributor Author

anden3 commented Jan 14, 2023

r? Nilstrieb

@rustbot rustbot assigned Noratrieb and unassigned oli-obk Jan 14, 2023
@Noratrieb
Copy link
Member

@bors r+ rollup
CI really shouldn't fail so I won't wait

@bors
Copy link
Collaborator

bors commented Jan 14, 2023

📌 Commit da3623a has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@Noratrieb
Copy link
Member

r? Nilstrieb

@anden3
Copy link
Contributor Author

anden3 commented Jan 14, 2023

I found some more, pushing another commit soon.

@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 14, 2023

📌 Commit 0e65003 has been approved by Nilstrieb

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 15, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106072 (fix: misleading "add dyn keyword before derive macro" suggestion)
 - rust-lang#106859 (Suggestion for type mismatch when we need a u8 but the programmer wrote a char literal)
 - rust-lang#106863 (Remove various double spaces in compiler source comments.)
 - rust-lang#106865 (Add explanation comment for GUI test)
 - rust-lang#106867 (Fix the stability attributes for `std::os::fd`.)
 - rust-lang#106878 (Add regression test for rust-lang#92157)
 - rust-lang#106879 (Add regression test for rust-lang#42114)
 - rust-lang#106880 (doc: fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cc02ecc into rust-lang:master Jan 15, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 15, 2023
@anden3 anden3 deleted the compiler-double-spaces branch January 15, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants