Skip to content

Enable doctests for rustc_query_impl #106436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

Enable doctests for rustc_query_impl #106436

merged 1 commit into from
Jan 4, 2023

Conversation

CarsonV
Copy link
Contributor

@CarsonV CarsonV commented Jan 4, 2023

doctests worked out of the box for query_impl on my local machine. Working towards #99144

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2023
@CarsonV
Copy link
Contributor Author

CarsonV commented Jan 4, 2023

@rustbot label: +A-testsuite

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 4, 2023
@CarsonV
Copy link
Contributor Author

CarsonV commented Jan 4, 2023

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned oli-obk Jan 4, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 4, 2023

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 4, 2023

📌 Commit f98adb3 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2023
@bors
Auto merge of rust-lang#106442 - matthiaskrgr:rollup-wivf7gh, r=matth…
5c18bc6 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106200 (Suggest `impl Fn*` and `impl Future` in `-> _` return suggestions)
 - rust-lang#106274 (Add JSON output to -Zdump-mono-stats)
 - rust-lang#106292 (Add codegen test for `Box::new(uninit)` of big arrays)
 - rust-lang#106327 (Add tidy check for dbg)
 - rust-lang#106361 (Note maximum integer literal for `IntLiteralTooLarge`)
 - rust-lang#106396 (Allow passing a specific date to `bump-stage0`)
 - rust-lang#106436 (Enable doctests for rustc_query_impl)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4e590b3 into rust-lang:master Jan 4, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CarsonV @rustbot @jyn514 @bors @oli-obk