Skip to content

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 27, 2022

There are some operator-checking flavored methods in FnCtxt that can be deduplicated.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2022

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2022
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 27, 2022

📌 Commit 8bf7ec7 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 28, 2022
…hods, r=jackh726

Deduplicate `op` methods

There are some operator-checking flavored methods in `FnCtxt` that can be deduplicated.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 28, 2022
…hods, r=jackh726

Deduplicate `op` methods

There are some operator-checking flavored methods in `FnCtxt` that can be deduplicated.
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#106028 (docs/test: add UI test and long-form error docs for `E0461`)
 - rust-lang#106172 (Suggest `impl Iterator` when possible for `_` return type)
 - rust-lang#106173 (Deduplicate `op` methods)
 - rust-lang#106176 (Recover `fn` keyword as `Fn` trait in bounds)
 - rust-lang#106194 (rustdoc: combine common sidebar background color CSS rules)
 - rust-lang#106199 (Silence knock-down errors on `[type error]` bindings)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c991c24 into rust-lang:master Dec 28, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 28, 2022
@compiler-errors compiler-errors deleted the deduplicate-op-methods branch August 11, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants