Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Dec 24, 2022

this seems to be have occurred in a recent edit, i clearly remember just note being bold

the entire note was bold

@rustbot
Copy link
Collaborator

rustbot commented Dec 24, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2022
@ghost ghost changed the title Make just "Note" bold in README.md Make note bold Dec 24, 2022
@jyn514
Copy link
Member

jyn514 commented Dec 24, 2022

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

📌 Commit a3cf585 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2022
@ghost
Copy link
Author

ghost commented Dec 24, 2022

@jyn514 look at the newer commit, the commit which is r+'ed just bolds "note", but i was wrong in that and the whole note was in bold

@ghost
Copy link
Author

ghost commented Dec 24, 2022

the new..new commit, my bad (ugh this is a mess)

@Dylan-DPC
Copy link
Member

@bors r=jyn

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

📌 Commit 93ebf46 has been approved by jyn

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 24, 2022

⌛ Testing commit 93ebf46 with merge 3468044...

@bors
Copy link
Collaborator

bors commented Dec 25, 2022

☀️ Test successful - checks-actions
Approved by: jyn
Pushing 3468044 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 25, 2022
@bors bors merged commit 3468044 into rust-lang:master Dec 25, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 25, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3468044): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.9% [3.9%, 3.9%] 1
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@ghost ghost deleted the patch-1 branch December 25, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants