Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 19, 2022

fixes #105816

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 19, 2022

@bors ping

@bors
Copy link
Collaborator

bors commented Dec 19, 2022

😪 I'm awake I'm awake

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 19, 2022

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Dec 19, 2022

📌 Commit e5c92bc has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 19, 2022
…Simulacrum

Don't panic on stable since miri is not available there

fixes rust-lang#105816
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2022
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#105901 (Don't panic on stable since miri is not available there)
 - rust-lang#105912 (rustdoc: force pre tags to have the default line height)
 - rust-lang#105914 (rustdoc: Simplify CSS for scraped code examples code blocks)
 - rust-lang#105933 (Add readable rustdoc display for tvOS and watchOS)
 - rust-lang#105935 (docs/test: add UI test and long-form error docs for `E0377`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bcb75e6 into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Jan 17, 2023
@paulmenzel
Copy link

As this is still happening in 1.66.1, is it possible to have it backported to 1.67.0?

@oli-obk oli-obk deleted the no_miri_on_stable branch January 18, 2023 12:21
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 18, 2023

I don't believe this warrants a backport, but we can bring it up in the compiler team triage on Thursday. If you open an issue for it and ping me there I can nominate it for a compiler team decision

@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.68.0, 1.67.0 Jan 19, 2023
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2023
…mulacrum

[beta] backport rollup

* Revert "Make nested RPITIT inherit the parent opaque's generics." rust-lang#106759
*  Fix mpsc::SyncSender spinning behavior rust-lang#106701
*  rustdoc: fix outdated lint section of the book rust-lang#106605
*  Do not filter substs in remap_generic_params_to_declaration_params. rust-lang#106503
*  Correct detection of elided lifetimes in impl-trait. rust-lang#106501
*  Bump rust-installer rust-lang#106196
*  Don't panic on stable since miri is not available there rust-lang#105901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable build of 1.66.0 fails due to 'missing miri'
5 participants