rustdoc: add comment to confusing CSS main { min-width: 0 }
#105064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
|
r? @CraftSpider (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
approved these changes
Nov 29, 2022
|
Thanks! r=me once CI pass |
This comment has been minimized.
This comment has been minimized.
This CSS was added in cad0fce, but the reason why it was necessary was unclear. This comment makes it clear.
notriddle
force-pushed
the
notriddle/main-min-width
branch
from
cb976a0 to
43f5d2b
Compare
notriddle
changed the title
main { min-width: 0 }main { min-width: 0 }
|
@GuillaumeGomez Luckily for us, the browser UI tests found a corner case where removing this rule broke the layout. |
|
Well, that's why we wrote them for. :) Thanks adding the comment! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 30, 2022
…, r=GuillaumeGomez
rustdoc: add comment to confusing CSS `main { min-width: 0 }`
This CSS was added in cad0fce, but the reason why it was necessary was unclear. This comment makes it clear.
This was referenced Nov 30, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 1, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103065 (rustdoc-json: Document and Test that args can be patterns.) - rust-lang#104865 (Don't overwrite local changes when updating submodules) - rust-lang#104895 (Avoid Invalid code suggested when encountering unsatisfied trait bounds in derive macro code) - rust-lang#105063 (Rustdoc Json Tests: Don't assume that core::fmt::Debug will always have one item.) - rust-lang#105064 (rustdoc: add comment to confusing CSS `main { min-width: 0 }`) - rust-lang#105074 (Add Nicholas Bishop to `.mailmap`) - rust-lang#105081 (Add a regression test for rust-lang#104322) - rust-lang#105086 (rustdoc: clean up sidebar link CSS) - rust-lang#105091 (add Tshepang Mbambo to .mailmap) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CSS was added in cad0fce, but the reason why it was necessary was unclear. This comment makes it clear.