Wrap bundled static libraries into object files #104091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Nov 7, 2022
petrochenkov
reviewed
Nov 9, 2022
petrochenkov
added
S-waiting-on-author
belovdv
force-pushed
the
issue-103044
branch
from
eaa7cda to
dc352f7
Compare
rustbot
added
the
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
belovdv
force-pushed
the
issue-103044
branch
from
dc352f7 to
ca3c0bc
Compare
belovdv
force-pushed
the
issue-103044
branch
from
ca3c0bc to
e16c778
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors p=100 CI has been migrated to macos-12, which is now failing. |
|
☀️ Test successful - checks-actions |
This was referenced Nov 15, 2022
|
Finished benchmarking commit (dedfb9c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This was referenced Nov 18, 2022
Merged
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Nov 20, 2022
The proper fix for this is rust-lang#104091, but we're avoiding a backport for it since this is just failing for an unstable feature.
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
Wrap bundled static libraries into object files Fixes rust-lang#103044 (not sure, couldn't test locally) Bundled static libraries should be wrapped into object files as it's done for metadata file. r? `@petrochenkov`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103044 (not sure, couldn't test locally)
Bundled static libraries should be wrapped into object files as it's done for metadata file.
r? @petrochenkov