Handle return-position impl Trait in traits properly in register_hidden_type
#103355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
compiler-errors
changed the title
register_hidden_typeimpl Trait in traits properly in register_hidden_type
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 22, 2022
…ck, r=oli-obk Handle return-position `impl Trait` in traits properly in `register_hidden_type` The bounds that we get by calling `bound_explicit_item_bounds` from an RPITIT have projections, not opaques, but when we're *registering* an opaque, we want to treat it like an opaque. Coincidentally fixes rust-lang#102688 as well, which makes sense, since that was failing because we were inferring an opaque type to be equal to itself (opaque cycle error => "cannot resolve opaque type"). Fixes rust-lang#103352 r? `@oli-obk`
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 22, 2022
…ck, r=oli-obk Handle return-position `impl Trait` in traits properly in `register_hidden_type` The bounds that we get by calling `bound_explicit_item_bounds` from an RPITIT have projections, not opaques, but when we're *registering* an opaque, we want to treat it like an opaque. Coincidentally fixes rust-lang#102688 as well, which makes sense, since that was failing because we were inferring an opaque type to be equal to itself (opaque cycle error => "cannot resolve opaque type"). Fixes rust-lang#103352 r? ``@oli-obk``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103123 (Introduce `subst_iter` and `subst_iter_copied` on `EarlyBinder` ) - rust-lang#103328 (Do not suggest trivially false const predicates) - rust-lang#103354 (Escape string literals when fixing overlong char literal) - rust-lang#103355 (Handle return-position `impl Trait` in traits properly in `register_hidden_type`) - rust-lang#103368 (Delay ambiguity span bug in normalize query iff not rustdoc) - rust-lang#103388 (rustdoc: remove unused CSS class `.result-description`) - rust-lang#103399 (Change `unknown_lint` applicability to `MaybeIncorrect`) - rust-lang#103401 (Use functions for headings rustdoc GUI test) - rust-lang#103412 (Fix typo in docs of `String::leak`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bounds that we get by calling
bound_explicit_item_boundsfrom an RPITIT have projections, not opaques, but when we're registering an opaque, we want to treat it like an opaque.Coincidentally fixes #102688 as well, which makes sense, since that was failing because we were inferring an opaque type to be equal to itself (opaque cycle error => "cannot resolve opaque type").
Fixes #103352
r? @oli-obk