Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 29, 2022

This file was way too big (adding a few lines of code caused tidy to trigger)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 29, 2022
@rust-highfive
Copy link
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2022
@lcnr
Copy link
Contributor

lcnr commented Sep 29, 2022

r? @lcnr

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 29, 2022

📌 Commit f22f149 has been approved by lcnr

It is now in the queue for this repository.

@rust-highfive rust-highfive assigned lcnr and unassigned jackh726 Sep 29, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2022
@bors
Copy link
Collaborator

bors commented Sep 29, 2022

⌛ Testing commit f22f149 with merge c5bbf36...

@bors
Copy link
Collaborator

bors commented Sep 29, 2022

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing c5bbf36 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2022
@bors bors merged commit c5bbf36 into rust-lang:master Sep 29, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c5bbf36): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.6%, -1.1%] 7
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.3% [3.7%, 5.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-5.8% [-5.8%, -5.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -5.8% [-5.8%, -5.8%] 1

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants