Skip to content

Conversation

fee1-dead
Copy link
Member

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 24, 2022
@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Sep 24, 2022

Does this enable implementing a trait non constly and constly for the same type? Either way, please add a test for that

@fee1-dead fee1-dead force-pushed the const_trait_impl_specialization branch from 9c9338e to 36e8c11 Compare September 24, 2022 20:32
@fee1-dead
Copy link
Member Author

Done.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 26, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 26, 2022

📌 Commit 36e8c11 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2022
@bors
Copy link
Collaborator

bors commented Sep 26, 2022

⌛ Testing commit 36e8c11 with merge 21265dd...

@bors
Copy link
Collaborator

bors commented Sep 26, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 21265dd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2022
@bors bors merged commit 21265dd into rust-lang:master Sep 26, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 26, 2022
@fee1-dead fee1-dead deleted the const_trait_impl_specialization branch September 26, 2022 11:50
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (21265dd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants