Skip to content

fix is_disaligned logic for nested packed structs #100064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix is_disaligned logic for nested packed structs #100064

merged 1 commit into from
Aug 3, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 2, 2022

#83605 broke the is_disaligned logic by bailing out of the loop in is_within_packed early. This PR fixes that problem and adds suitable tests.

Fixes #99838

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 2, 2022
@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 2, 2022
@RalfJung RalfJung mentioned this pull request Aug 2, 2022
Closed
JakobDegen
JakobDegen approved these changes Aug 2, 2022
View reviewed changes
@petrochenkov
Copy link
Contributor

r=me after squashing commits.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Aug 3, 2022

@bors r=petrochenkov p=1
let's get this soundness fix in before beta branches on Friday

@bors
Copy link
Collaborator

bors commented Aug 3, 2022

📌 Commit 9097ce9 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 3, 2022
@bors
Copy link
Collaborator

bors commented Aug 3, 2022

⌛ Testing commit 9097ce9 with merge d6b96b6...

@bors
Copy link
Collaborator

bors commented Aug 3, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d6b96b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2022
@bors bors merged commit d6b96b6 into rust-lang:master Aug 3, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 3, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d6b96b6): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.6% -3.6% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 2.0% 2.1% 2
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.0% 2.1% 2

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@RalfJung RalfJung deleted the disaligned branch August 3, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobDegen JakobDegen JakobDegen approved these changes

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

Misaligned reference from drop field in packed struct
7 participants
@RalfJung @rust-highfive @petrochenkov @bors @rust-timer @JakobDegen @rustbot