Properly reject the may_unwind option in global_asm!
#100045
Merged
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This was accidentally accepted even though it had no effect in `global_asm!`. The option only makes sense for `asm!` which runs within a function.
Amanieu
force-pushed
the
global_asm_may_unwind
branch
from
4e582b5 to
96c955e
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 2, 2022
…miasko Properly reject the `may_unwind` option in `global_asm!` This was accidentally accepted even though it had no effect in `global_asm!`. The option only makes sense for `asm!` which runs within a function.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#99987 (Always include a position span in `rustc_parse_format::Argument`) - rust-lang#100005 (Remove Clean trait for ast::Attribute and improve Attributes::from_ast) - rust-lang#100025 (Remove redundant `TransferWrapper` struct) - rust-lang#100045 (Properly reject the `may_unwind` option in `global_asm!`) - rust-lang#100052 (RISC-V ASM test: relax label name constraint.) - rust-lang#100053 (move [`assertions_on_result_states`] to restriction) - rust-lang#100057 (Remove more Clean trait implementations) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was accidentally accepted even though it had no effect in
global_asm!. The option only makes sense forasm!which runs withina function.