Should include crate name in error message for E0391 (and perhaps others)

[pnkfelix]

While doing a bootstrap build of the compiler with some other build artifacts lying around, I saw the following error message (a small snippet from whole output):

[RUSTC-TIMING] cfg_if test:false 0.035
   Compiling lock_api v0.3.4
[RUSTC-TIMING] scopeguard test:false 0.068
   Compiling crossbeam-utils v0.6.5
   Compiling tracing-core v0.1.10
   Compiling log_settings v0.1.2
error[E0391]: cycle detected when running analysis passes on this crate
  |
  = note: ...which again requires running analysis passes on this crate, completing the cycle

error: aborting due to previous error

For more information about this error, try `rustc --explain E0391`.
error[E0391]: cycle detected when running analysis passes on this crate
  |
  = note: ...which again requires running analysis passes on this crate, completing the cycle

[RUSTC-TIMING] lazy_static test:false 0.079
error: aborting due to previous error

It is sub-optimal to say "on this crate" in a diagnostic like this.

Multiple crates can be compiled in parallel, and thus it can be ambiguous which crate a diagnostic like that is associated with.

In general it would be better to extract a crate name, if possible, and include that in the message, rather than using the simpler-but-potentially-ambiguous "on this crate."

[pnkfelix]

(I didn't attempt to include a code snippet because I suspect that this particular instance of the problem is arising due to bootstrap build artifacts lying around. If I do happen to make a MCVE, I'll include it. But I assume this problem can be fixed without needing a whole new MCVE, since presumably we already have test cases for E0391.)

See in particular tests like the following in src/test/ui:

rg "on this crate"

associated-consts/issue-24949-assoc-const-static-recursion-impl.stderr
40:   = note: cycle used when running analysis passes on this crate

associated-consts/issue-24949-assoc-const-static-recursion-trait-default.stderr
40:   = note: cycle used when running analysis passes on this crate

associated-consts/issue-24949-assoc-const-static-recursion-trait.stderr
40:   = note: cycle used when running analysis passes on this crate

issues/issue-23302-3.stderr
35:   = note: cycle used when running analysis passes on this crate

However, none of those are actually emitting the exact error I am witnessing, which is precisely "error[E0391]: cycle detected when running analysis passes on this crate"

(that is, I don't see any ui tests checking for "when running analysis passes on this crate")