Skip to content

Revisit trailing tokens in assert!Β #69531

Closed
@adlerd

Description

@adlerd

About 10 months ago it was necessary to permit typos to become temporary non-errors due to #60024 slipping into a stable release. Since #60039, the compiler has issued a "this will become an error" warning for a subset of accidentally-allowed uses (Playground):

fn main() {
    assert!(true "whatever");      // Intended: error. Currently: warning.
    assert!(true;);                // Intended: error. Currently: warning.
    assert!(true some extra junk); // Intended: error. Currently: error.
}

Version: 1.43.0 2020-02-26 nightly

Since the fix has been in for far longer than the bug, it would be great to close the loop on this by removing the special cases or converting them to errors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.C-future-incompatibilityCategory: Future-incompatibility lintsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-help-wantedCall for participation: Help is requested to fix this issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions