TcpStream (and probably more std::net types) missing Debug impl

[carllerche]

It seems like these types could implement Debug (allowing structs that contain std::net values to be able to derive Debug).

cc @alexcrichton

[wesleywiser]

Hi, if it's ok, I'd like to work on this issue. I have a commit in my local repo which resolves this but I need to test it some more to be sure. Hopefully, I can open a PR with the changes later tonight.

[sfackler]

Sure!

[wesleywiser]

@sfackler Hi, I'm trying to test my changes but I'm running into an issue. make help says that running make all should result in rustc being in ${platform}/stage2/bin but when I run ./rustc from that directory, I get:

./rustc: symbol lookup error: ./rustc: undefined symbol: _ZN2rt10lang_start20hd326254c68b07ef5NFJE

Any ideas?

[sfackler]

You need to set your LD_LIBRARY_PATH on linux or DYLD_LIBRARY_PATH on osx to have it point to the right set of libraries - it should be set to ${platform}/stage2/lib.

[wesleywiser]

Thanks, that did the trick.

I found several types in std::net that didn't implement Debug. After my changes this is what they output:

• Shutdown: Read or Write or Both
• TcpStream: TcpStream { addr: Ok(127.0.0.1:1234) }
• TcpListener: TcpListener { addr: Ok(127.0.0.1:1234) }
• UdpSocket: UdpSocket { addr: Ok(127.0.0.1:1234) }

Does that look right? Should I try to get rid of the inner Oks?

[wesleywiser]

@sfackler Sorry, I think I forgot to mention you in that last comment.

[sfackler]

Ah yeah, sorry. I'd go without the Ok wrappers personally. It's probably also a good idea to put the file descriptor itself in the debug message as well.

[nham]

@wesleywiser Are you still working on this?