-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
The original infra PR setting up rmake.rs
version of run-make tests copied over the logic for the legacy Makefile
version, which ran the test with the test sources directory as the CWD, which is Very Naughty because if you aren't careful with relative paths, you suddenly can produce output artifacts into your test sources directory. Oops.
We should stop doing that.
cc @Kobzol as they wanted to work on a fix for this.
Metadata
Metadata
Labels
A-compiletestArea: The compiletest test runnerArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.