-
Notifications
You must be signed in to change notification settings - Fork 68
Add goal to run more GCC tests in rust CI #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would clarify on which targets this should be running (probably only x64 Linux for now?), and add a work item for extending documentation, so that contributors know what to do in the case of failure.
33b119f
to
29c64c3
Compare
Very good points, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making CI pass
src/2025h2/gcc-backend-tests.md
Outdated
| Task | Owner(s) or team(s) | Notes | | ||
|-------------------------------|---------------------|-------| | ||
| Adding new ui annotations | @GuillaumeGomez | | | ||
| Running more GCC backend tests | @GuillaumeGomez with the help of t-infra and t-compiler for reviews and ensuring is done as they want | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well, asks are codified for tooling purposes.
| Running more GCC backend tests | @GuillaumeGomez with the help of t-infra and t-compiler for reviews and ensuring is done as they want | | | |
| Running more GCC backend tests | @GuillaumeGomez | | | |
| Standard reviews | ![Team][] [infra], [compiler] | with the help of t-infra and t-compiler for reviews and ensuring is done as they want | |
29c64c3
to
d76d6db
Compare
Thanks! Applied suggestion. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exciting but also a significant step (testing a new backend).
cc rust-lang/compiler-team#891
cc @antoyo (maintainer of the GCC backend)
cc @Kobzol (for bootstrap/infra team)
cc @rust-lang/compiler (directly impacted by this goal)
Rendered