Use new spanned diagnostics #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
annotate-snippets
branch
2 times, most recently
from
1b66c69 to
f9bf422
Compare
oli-obk
force-pushed
the
annotate-snippets
branch
from
f9bf422 to
909a2b1
Compare
nikomatsakis
approved these changes
Jul 21, 2025
|
looks like I need to rebase |
|
@oli-obk I think I fixed it? |
|
oh that works, too XD but I do have a rebased version if you prefer |
|
@oli-obk sure, go ahead and push, then I'll merge |
nikomatsakis
approved these changes
Jul 21, 2025
|
@oli-obk I got impatient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also use the latest
spannedcrate, so even with debug prints one won't get the[0..0]byte offset messages anymoreDiagnostics now look like
pointing to both the source code that emitted the error as well as the processed text during whose processing the error occurred