Skip to content

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Oct 20, 2025

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Comment on lines -3 to +4
GitHub native compare feature shows lots of unrelated changes when a force push changes the base commit of a PR. This handler post a comment after such scenario which links to triagebot `range-diff` feature.
GitHub native compare feature shows lots of unrelated changes when a force push changes the base commit of a PR.
This handler posts a comment after such a scenario, which links to triagebot `range-diff` feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here the actual diff is just:

+ This handler posts
- This handler post

Just thinking if there is way to optimize the review time on these tiny fixes you're pushing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comma as well, to make it more clear/easy to read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants