Skip to content

Conversation

karolzwolak
Copy link
Member

@karolzwolak karolzwolak commented Aug 15, 2025

Right now, good first issues link to issues with the E-help-wanted label, even though this shows hard issues too (E-hard). I replaced help wanted label with E-easy label.

Rendered

Right now, good first issues link to issues with the E-help-wanted label, even though this shows hard issues too (E-hard). 
I replaced help wanted label with E-easy label.
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2025
@ehuss
Copy link
Contributor

ehuss commented Aug 16, 2025

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned ehuss Aug 16, 2025
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some help-wanted issues that are not marked with E-easy, but might not be particularly hard (e.g. rust-lang/rust#137286).

I think that it is better to show more issues on the link, even if some of them will already be claimed, or not easy for a beginner, to give people inspiration, and areas into which they could look into. I don't expect that most people will actually immediately find the perfect issue for them on the given link.

@karolzwolak
Copy link
Member Author

even if some of them will already be claimed

But it links only to the unclaimed issues:

[rustc-issues]: https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AE-help-wanted+no%3Aassignee

or not easy for a beginner, to give people inspiration, and areas into which they could look into. I don't expect that most people will actually immediately find the perfect issue for them on the given link.

Okay, valid points, so maybe the link should be called 'Help wanted' instead of 'good first issues', like rustup issues for example?

| [Rust playground][playground-repo] | | [Help wanted][playground-issues] | Rust online playground |

@Kobzol
Copy link
Member

Kobzol commented Aug 17, 2025

But it links only to the unclaimed issues:

I meant "unclaimed" as in "no one worked on them yet". You can notice that some issues on the link you posted are not strictly claimed, but already have a linked PR :) We don't actually use issue claiming that much, although for beginner issues it's more common.

Renaming the link sounds good :)

@karolzwolak
Copy link
Member Author

Right, I did notice that some issues weren't claimed, but they still had a PR linked. Closing this in favor of #933.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants