Skip to content

manual_let_else: keep macro call on suggestion blocks #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

dswij
Copy link
Member

@dswij dswij commented Nov 25, 2022

Closes #9940

changelog: [manual_let_else]: Do not expand macro calls on suggestions

@rust-highfive
Copy link

r? @Jarcho

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 25, 2022
@Jarcho
Copy link
Contributor

Jarcho commented Nov 26, 2022

snippet_with_context would be better here. snippet_with_macro_callsite should be removed since it doesn't handle nested macro calls.

@Jarcho
Copy link
Contributor

Jarcho commented Nov 30, 2022

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2022

📌 Commit c502dee has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 30, 2022

⌛ Testing commit c502dee with merge ee12b12...

@bors
Copy link
Contributor

bors commented Nov 30, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing ee12b12 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_let_else suggestion expands macros
4 participants