Skip to content

Conversation

tamaroning
Copy link
Contributor

@tamaroning tamaroning commented Jun 30, 2022

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 30, 2022
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can this be corrected together?

@tamaroning
Copy link
Contributor Author

Okey. Fixed it:)

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jun 30, 2022

📌 Commit 5d9e1b6 has been approved by giraffate

@bors
Copy link
Contributor

bors commented Jun 30, 2022

⌛ Testing commit 5d9e1b6 with merge b9da145...

@bors
Copy link
Contributor

bors commented Jun 30, 2022

💔 Test failed - checks-action_test

@xFrednet
Copy link
Contributor

The changelog entry was missing

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2022

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Jun 30, 2022

📌 Commit 5d9e1b6 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Jun 30, 2022

⌛ Testing commit 5d9e1b6 with merge d4c5078...

@xFrednet
Copy link
Contributor

@bors r-

@xFrednet
Copy link
Contributor

@bors r=giraffate,xFrednet

@bors
Copy link
Contributor

bors commented Jun 30, 2022

📌 Commit 5d9e1b6 has been approved by giraffate,xFrednet

@bors
Copy link
Contributor

bors commented Jun 30, 2022

⌛ Testing commit 5d9e1b6 with merge ff3964a...

@matthiaskrgr
Copy link
Member

if we only had some kind of linter that could catch these kind of typos automatically.. 😔

@bors
Copy link
Contributor

bors commented Jun 30, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate,xFrednet
Pushing ff3964a to master...

@bors bors merged commit ff3964a into rust-lang:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants