Skip to content

Replace expr_visitor with for_each_expr #8762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2022
Merged

Replace expr_visitor with for_each_expr #8762

merged 3 commits into from
Oct 3, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 29, 2022

This is a minor change which uses ControlFlow rather than a boolean. This also runs the visitor rather than returning the visitor, which results in a small readability win as well.

changelog: None

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 29, 2022
@bors
Copy link
Contributor

bors commented May 3, 2022

☔ The latest upstream changes (presumably #8779) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the visitor branch 3 times, most recently from e95d3f2 to 9cfba1a Compare August 20, 2022 01:43
@Jarcho
Copy link
Contributor Author

Jarcho commented Aug 20, 2022 •
edited
Loading

Great. The compiler broke... Looks like rust-lang/rust#99866.

@flip1995
Copy link
Member

LGTM. Will merge after the next sync.

@flip1995 flip1995 mentioned this pull request Aug 21, 2022
Closed
@bors
Copy link
Contributor

bors commented Sep 8, 2022

☔ The latest upstream changes (presumably #9447) made this pull request unmergeable. Please resolve the merge conflicts.

@flip1995
Copy link
Member

flip1995 commented Sep 9, 2022

Huh. Forgot about it. Can you rebase and then r+ yourself, if CI passes?

@Jarcho Jarcho force-pushed the visitor branch 2 times, most recently from cecb4ea to 823a859 Compare September 10, 2022 23:33
@Jarcho
Copy link
Contributor Author

Jarcho commented Sep 10, 2022

Looks like this is still broken. rust-lang/rust#101410 is a possible fix.

@bors
Copy link
Contributor

bors commented Sep 12, 2022

☔ The latest upstream changes (presumably #9458) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho
Copy link
Contributor Author

Jarcho commented Oct 3, 2022

Narrowed the issue down to something with let-chains mir opt levels. Pretty good match with rust-lang/#99852. Just added a workaround until the rustc bug is fixed.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 3, 2022

📌 Commit 26bb366 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 3, 2022

⌛ Testing commit 26bb366 with merge 2be6c4a...

@bors
Copy link
Contributor

bors commented Oct 3, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 2be6c4a to master...

@bors bors merged commit 2be6c4a into rust-lang:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jarcho @rust-highfive @bors @flip1995 @giraffate