Skip to content

Conversation

xFrednet
Copy link
Contributor

roses are red,
violets are blue,
this changelog,
is no longer a todo!


changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 14, 2022
@xFrednet xFrednet force-pushed the 0000-changelog-1-61 branch 2 times, most recently from 9b143cf to 60184eb Compare April 14, 2022 09:47
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks!

@xFrednet xFrednet force-pushed the 0000-changelog-1-61 branch from 258c662 to dbb7262 Compare April 15, 2022 16:13
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please squash the 2 commits and then r=me 👍

@xFrednet xFrednet force-pushed the 0000-changelog-1-61 branch from dbb7262 to af72103 Compare April 16, 2022 08:25
@xFrednet
Copy link
Contributor Author

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Apr 16, 2022

📌 Commit af72103 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Apr 16, 2022

⌛ Testing commit af72103 with merge 3abd2c0...

@bors
Copy link
Contributor

bors commented Apr 16, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 3abd2c0 to master...

@bors bors merged commit 3abd2c0 into rust-lang:master Apr 16, 2022
@xFrednet xFrednet deleted the 0000-changelog-1-61 branch April 16, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants