Lint enum-to-int casts with cast_possible_truncation
#8381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
cast_possible_truncation_542
branch
2 times, most recently
from
d275208 to
ece4d65
Compare
Manishearth
approved these changes
Feb 3, 2022
|
☔ The latest upstream changes (presumably #8419) made this pull request unmergeable. Please resolve the merge conflicts. |
Jarcho
force-pushed
the
cast_possible_truncation_542
branch
3 times, most recently
from
99d7050 to
5ed4827
Compare
Jarcho
force-pushed
the
cast_possible_truncation_542
branch
from
5ed4827 to
88ecdd0
Compare
|
@bors r+ |
|
📌 Commit 88ecdd0 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #542
This will not lint casting a specific variant to an integer. That really should be a new lint as it's definitely a truncation (other thanisize/usizevalues).changelog: Lint enum-to-int casts with
cast_possible_truncationchangelog: New lint
cast_enum_truncation