Skip to content

Conversation

@Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 15, 2021

fixes: #3864

Indentation checks could be added as well, but the lint already doesn't check for it.

changelog: Allow allman style braces in suspicious_else_formatting

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 15, 2021
@Jarcho Jarcho force-pushed the allman_style_else branch from 10ad06e to f44b933 Compare April 16, 2021 00:32
@Jarcho Jarcho force-pushed the allman_style_else branch from f44b933 to 3c70e73 Compare April 16, 2021 18:59
@camsteffen
Copy link
Contributor

r=me after squash

@Jarcho Jarcho force-pushed the allman_style_else branch from 3c70e73 to 559dedd Compare April 16, 2021 19:25
@camsteffen
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2021

📌 Commit 559dedd has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Apr 16, 2021

⌛ Testing commit 559dedd with merge 831c157...

@bors
Copy link
Contributor

bors commented Apr 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 831c157 to master...

@bors bors merged commit 831c157 into rust-lang:master Apr 16, 2021
@wareya
Copy link

wareya commented Apr 17, 2021

I opened the referenced issue; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allman style brace formatting triggers suspicious_else_formatting

5 participants