Skip to content

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Apr 3, 2021

This PR follows rust-lang/cargo#9282, I'm not fully informed about all of this, it would be great if somebody knowledgeable about this topic agrees.

changelog: Changed cargo_common_metadata to stop linting on the optional author field.

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 3, 2021
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we still want the authors field in Clippy. But not a blocker for this PR.

@camsteffen
Copy link
Contributor

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Apr 5, 2021

📌 Commit 5102c9c has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Apr 5, 2021

⌛ Testing commit 5102c9c with merge 1a45e43...

@bors
Copy link
Contributor

bors commented Apr 5, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 1a45e43 to master...

@bors bors merged commit 1a45e43 into rust-lang:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants