Skip to content

Conversation

camsteffen
Copy link
Contributor

changelog: none

This should wrap up the utils-related really big changes. I personally don't see any more sub-modules to be added to clippy_utils.

@rust-highfive
Copy link

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 16, 2021
@camsteffen
Copy link
Contributor Author

Fun fact: With all theses utils changes, the number of multi-line utils imports went from 55 to 7!

@bors
Copy link
Contributor

bors commented Mar 17, 2021

☔ The latest upstream changes (presumably #6917) made this pull request unmergeable. Please resolve the merge conflicts.

@camsteffen
Copy link
Contributor Author

camsteffen commented Mar 17, 2021

Rebased and added paths imports

@flip1995
Copy link
Member

This will collide with pretty much every PR, but mostly with #6896. But I think rebasing everything else on this is easier, than rebasing this. So...

@bors r+ p=10

Thanks! (I really like the net -55 LoC)

@bors
Copy link
Contributor

bors commented Mar 17, 2021

📌 Commit 565400d has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 17, 2021

⌛ Testing commit 565400d with merge 6595d55...

@camsteffen
Copy link
Contributor Author

This will collide with pretty much every PR

Sorry everybody.

@bors
Copy link
Contributor

bors commented Mar 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6595d55 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants