Skip to content

Conversation

smoelius
Copy link
Contributor

This small change ensures that if the diagnostic functions are called from outside of Clippy, a docs link is not displayed.


Please write a short comment explaining your change (or "none" for internal only changes)
changelog: restrict docs links

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 16, 2021
@llogiq
Copy link
Contributor

llogiq commented Mar 16, 2021

Thank you! I'm curious where this is called outside of clippy, but that shouldn't block this PR. @bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2021

📌 Commit f7c5742 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Mar 16, 2021

⌛ Testing commit f7c5742 with merge 1a206fc...

@bors
Copy link
Contributor

bors commented Mar 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 1a206fc to master...

@bors bors merged commit 1a206fc into rust-lang:master Mar 16, 2021
@smoelius
Copy link
Contributor Author

I'm curious where this is called outside of clippy...

To the best of my knowledge, only in some code that I was testing, and not in any published code yet.

Thanks a lot!

@smoelius smoelius deleted the docs-link branch March 1, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants