Skip to content

Conversation

matthiaskrgr
Copy link
Member

This pr:

  • moves lintcheck out of clippy dev and into its own crate (lintcheck) (I should have done this earlier :D)
  • makes lintcheck terminate if it is not launched from the repo root (to prevent problems with wrong paths when using cargo run in the crate root)
  • fixes json lint messages leaking the runners $HOME when a lint messages comes from a proc macro that originates from a crate inside the $CARGO_CACHE
  • adds more documentation to lintchecks README.md and mentions lintcheck in docs/basics.md

changelog: none

This will terminate the program if run via "cargo run".
"cargo run" does currently not work because at least a bunch of paths do not take that into account.
… deps would sneak in absolute paths to registry sources.

make the path a relative path that starts at the CARGO_HOME to not print the users home location in the log
also hook lintcheck into clippy-dev so that `clippy dev fmt` formats it.
@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 11, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2021

📌 Commit 0af90fd has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Mar 11, 2021

⌛ Testing commit 0af90fd with merge 534a13d...

@bors
Copy link
Contributor

bors commented Mar 11, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 534a13d to master...

@bors bors merged commit 534a13d into rust-lang:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants