Skip to content

Fix suspicious_map false positives #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix suspicious_map false positives #6831

merged 2 commits into from
Mar 15, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: Fix suspicious_map false positives

Fixes #5253
Replaces #5375

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 2, 2021
@bors
Copy link
Contributor

bors commented Mar 7, 2021

☔ The latest upstream changes (presumably #6823) made this pull request unmergeable. Please resolve the merge conflicts.

@camsteffen camsteffen force-pushed the suspicious-map branch 2 times, most recently from 2856c91 to 3f11be7 Compare March 7, 2021 23:34
@bors
Copy link
Contributor

bors commented Mar 8, 2021

☔ The latest upstream changes (presumably #6807) made this pull request unmergeable. Please resolve the merge conflicts.

Y-Nak
Y-Nak reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the ICE.

Y-Nak
Y-Nak reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I overlooked something.

@bors
Copy link
Contributor

bors commented Mar 11, 2021

☔ The latest upstream changes (presumably #6881) made this pull request unmergeable. Please resolve the merge conflicts.

@camsteffen
Copy link
Contributor Author

  • Rebased (including methods mod refactor)
  • Check arg counts
  • Ensure map is Iterator method

Y-Nak
Y-Nak reviewed Mar 15, 2021
View reviewed changes
Y-Nak
Y-Nak approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@flip1995 Ready for final review.

@flip1995
Copy link
Member

flip1995 commented Mar 15, 2021 •
edited
Loading

Thanks! @Y-Nak great catch with the ICE, I probably would've missed that.

bors r+

@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Mar 15, 2021
@bors
Auto merge of #6831 - camsteffen:suspicious-map, r=flip1995
bfad923 
Fix suspicious_map false positives

changelog: Fix suspicious_map false positives

Fixes #5253
Replaces #5375
@flip1995
Copy link
Member

@bors r=Y-Nak,flip1995 (correctly attributing the reviewers)

@bors
Copy link
Contributor

bors commented Mar 15, 2021

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Mar 15, 2021

📌 Commit 59dba04 has been approved by Y-Nak,flip1995

@bors
Copy link
Contributor

bors commented Mar 15, 2021

⌛ Testing commit 59dba04 with merge a611b11...

bors added a commit that referenced this pull request Mar 15, 2021
@bors
Auto merge of #6831 - camsteffen:suspicious-map, r=Y-Nak,flip1995
a611b11 
Fix suspicious_map false positives

changelog: Fix suspicious_map false positives

Fixes #5253
Replaces #5375
@bors
Copy link
Contributor

bors commented Mar 15, 2021

💔 Test failed - checks-action_test

@camsteffen
Copy link
Contributor Author

@bors retry

@bors
Copy link
Contributor

bors commented Mar 15, 2021

@camsteffen: 🔑 Insufficient privileges: not in try users

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 15, 2021

⌛ Testing commit 59dba04 with merge 0e042d2...

@bors
Copy link
Contributor

bors commented Mar 15, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Y-Nak,flip1995
Pushing 0e042d2 to master...

@bors bors merged commit 0e042d2 into rust-lang:master Mar 15, 2021
@bors bors mentioned this pull request Mar 15, 2021
Merged
@ThibsG ThibsG mentioned this pull request Mar 22, 2021
Closed
@camsteffen camsteffen deleted the suspicious-map branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Y-Nak Y-Nak Y-Nak approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suspicious_map oddity
6 participants
@camsteffen @rust-highfive @bors @flip1995 @Y-Nak @mathstuf