Skip to content

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Feb 9, 2021

  • Explain why tokei is commented out in the lintcheck sources.
  • If we specify a custom sources.toml, don't override the preexisting lintcheck logs, but rather start a new log with the filename depending on the sources.toml name.
  • Start adding a readme.md to clippy_dev and add some information on how to use the lintcheck subcommand.
  • Add support for path/local sources (I needed this for the next item which is: )
  • Collect ICEs that happen while clippy checks crates

changelog: more lintcheck changes

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 9, 2021
@matthiaskrgr matthiaskrgr force-pushed the lintcheck branch 2 times, most recently from 5aef977 to 0810b30 Compare February 10, 2021 12:54
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the formatting of the README. Otherwise LGTM

@@ -0,0 +1,26 @@
## Clippy-dev is a tool to ease clippys development, similar to `rustc`s `x.py`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Clippy-dev is a tool to ease clippys development, similar to `rustc`s `x.py`.
# Clippy Dev Tool
The Clippy Dev Tool is a tool to ease Clippys development, similar to `rustc`s `x.py`.


Functionalities (incomplete):

# lintcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# lintcheck
## `lintcheck`

@matthiaskrgr
Copy link
Member Author

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Feb 11, 2021

📌 Commit a6d493d has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 11, 2021

⌛ Testing commit a6d493d with merge 8dbcffe...

@bors
Copy link
Contributor

bors commented Feb 11, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8dbcffe to master...

@bors bors merged commit 8dbcffe into rust-lang:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants