Skip to content

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Jul 3, 2020

changelog: none

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 3, 2020
@flip1995
Copy link
Member Author

flip1995 commented Jul 3, 2020

r? @Manishearth

What should we have as a policy for future rustups? Since there is not much to review, should I just merge them myself or should someone else review them before merging?

@rust-highfive rust-highfive assigned Manishearth and unassigned phansch Jul 3, 2020
@Manishearth
Copy link
Member

@bors r+

@flip1995 yeah i think it's fine if a clippy team member self-r+s . This is what we used to do for rustc-side clippyup PRs in the past, and this is essentially the same thing :)

@bors
Copy link
Contributor

bors commented Jul 3, 2020

📌 Commit a7c58e6 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jul 3, 2020

⌛ Testing commit a7c58e6 with merge c493090...

@bors
Copy link
Contributor

bors commented Jul 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c493090 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants