Skip to content

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Jul 2, 2020

Some improvements for type_repetition_in_bounds:

Fixes #4380,
Fixes #4323,
Fixes #4326,
Closes #3764

changelog: Fix multiple FPs in type_repetition_in_bounds and add a configuration option

Note: the #3764 has already been fixed but not closed

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 2, 2020
@ThibsG ThibsG changed the title Add configurable threshold for type_repetition_in_bounds lint [WIP] Add configurable threshold for type_repetition_in_bounds lint Jul 3, 2020
@ThibsG ThibsG changed the title [WIP] Add configurable threshold for type_repetition_in_bounds lint [WIP] Improvements for type_repetition_in_bounds lint Jul 3, 2020
@ThibsG ThibsG changed the title [WIP] Improvements for type_repetition_in_bounds lint Improvements for type_repetition_in_bounds lint Jul 3, 2020
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! waiting for rustup

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 3, 2020
@flip1995
Copy link
Member

flip1995 commented Jul 3, 2020

@ThibsG you will need to rebase and change every Late{LintPass,Context}<'_, '_> -> Late{LintPass,Context}<'_> (remove the first LT parameter)

@ThibsG ThibsG force-pushed the TypeRepetitionThreshold branch from 0566e28 to 2d5930a Compare July 3, 2020 15:44
@ThibsG
Copy link
Contributor Author

ThibsG commented Jul 3, 2020

Actually simple rebase did the job

@flip1995
Copy link
Member

flip1995 commented Jul 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2020

📌 Commit 2d5930a has been approved by flip1995

@bors
Copy link
Contributor

bors commented Jul 3, 2020

⌛ Testing commit 2d5930a with merge fff8e72...

@bors
Copy link
Contributor

bors commented Jul 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing fff8e72 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
4 participants