result_map_unwrap_or_else: drop the .ok() in the suggestion
#4728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This should not be merged until |
Adding the `.ok()` changes the semantics since that assumes that `g` was ignoring its argument. Instead, allow `g` to keep taking its argument and preserve the isomorphism to the original code in the suggestion. Fixes rust-lang#1590
mathstuf
force-pushed
the
improve-result-map-unwrap_or_else
branch
from
c273af2 to
b546fd3
Compare
|
In the meantime, should the |
|
Sure, or fix it to only fire when |
flip1995
added
the
S-blocked
|
Superseded by #4848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
.ok()changes the semantics since that assumes thatgwasignoring its argument. Instead, allow
gto keep taking its argumentand preserve the isomorphism to the original code in the suggestion.
Fixes #1590
Cc: @gendx @Arnavion
changelog: fix result_map_unwrap_or_else suggestion to preserve isomorphism