Skip to content

Re-factor format lint #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2019
Merged

Re-factor format lint #4439

merged 4 commits into from
Aug 23, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 23, 2019 •
edited
Loading

cc #4432

changelog: none

@phansch
Copy link
Contributor

phansch commented Aug 23, 2019

Retriggering the build

@phansch phansch closed this Aug 23, 2019
@phansch phansch reopened this Aug 23, 2019
@tesuji tesuji force-pushed the fix-format branch 2 times, most recently from b390aef to 7e7100f Compare August 23, 2019 08:02
@phansch
Copy link
Contributor

phansch commented Aug 23, 2019 •
edited
Loading

@lzutao looks like only some dogfood tests need to be fixed: https://travis-ci.com/rust-lang/rust-clippy/jobs/227661145#L1079

error: this constant should be before the previous constant due to lexical ordering
 --> clippy_lints/src/utils/paths.rs:31:1
   |
31 | pub const FMT_ARGUMENTS_NEW_V1: [&str; 4] = ["core", "fmt", "Arguments", "new_v1"];
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D clippy::clippy-lints-internal` implied by `-D clippy::internal`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clippy_lints_internal

r=me with tests passing

@tesuji
Copy link
Contributor Author

tesuji commented Aug 23, 2019

CI is green.

@phansch
Copy link
Contributor

phansch commented Aug 23, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Aug 23, 2019

📌 Commit ab335ea has been approved by phansch

@bors
Copy link
Contributor

bors commented Aug 23, 2019

⌛ Testing commit ab335ea with merge 7a11843...

bors added a commit that referenced this pull request Aug 23, 2019
@bors
Auto merge of #4439 - lzutao:fix-format, r=phansch
7a11843 
Re-factor format lint

cc #4432

changelog: none
@phansch phansch mentioned this pull request Aug 23, 2019
Closed
mati865
mati865 reviewed Aug 23, 2019
View reviewed changes
tests/ui/format.stderr
--> $DIR/format.rs:69:18
|
LL | let _ = Some(format!("{}", a + "bar"));
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `a + "bar"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this should be not linted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should. I forgot to removing the misleading comments.

@bors
Copy link
Contributor

bors commented Aug 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 7a11843 to master...

@bors bors merged commit ab335ea into rust-lang:master Aug 23, 2019
@tesuji tesuji deleted the fix-format branch August 23, 2019 10:58
@flip1995 flip1995 mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mati865 mati865 mati865 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tesuji @phansch @bors @mati865