Fix lint_without_lint_pass #3378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
|
Looks like I broke something. I'll try again tomorrow. |
|
Not only the declared lint collection was broken, but also the registered lint collection. The old code of the registered lint collection seemed a little bit weird to me, so I decided to rewrite it. |
|
Oh @mikerite sorry I stole this from you, but this lint triggered or didn't trigger in weird ways and I wanted to look into this myself. cc #3367 (comment) |
flip1995
added
the
S-waiting-on-review
|
No problem. Your changes look good to me. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2018
3378: Fix lint_without_lint_pass r=phansch a=mikerite Co-authored-by: Michael Wright <[email protected]> Co-authored-by: flip1995 <[email protected]>
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.