Move replace_box into nursery
#15974
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`replace_box` is a new `perf` lint in Rust 1.92 which detects assignments of a newly created `Box` over an existing box instead of replacing the box content. However, the lint triggers even when the target of the assignment has been moved and is no longer replaceable without reassignment. Until this is fixed, this lint is moved to `nursery`.
rustbot
added
the
S-waiting-on-review
rustbot
added
the
beta-nominated
|
Lintcheck changes for d1e83ee
This comment will be updated if you push new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace_boxis a newperflint in Rust 1.92 which detects assignments of a newly createdBoxover an existing box instead of replacing the box content.However, the lint triggers even when the target of the assignment has been moved and is no longer replaceable without reassignment. Until this is fixed, this lint is moved to
nursery.changelog: [
replace_box]: move to nursery until a known bug has been fixedr? flip1995
Summary Notes
Managed by
@rustbot—see help for details