Skip to content

refactor(integer_division_remainder_used): move to under operators #15953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

refactor(integer_division_remainder_used): move to under operators #15953

merged 2 commits into from
Oct 29, 2025
+60 −62

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 25, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 25, 2025
@ada4a ada4a removed the needs-fcp label Oct 25, 2025
@ada4a ada4a force-pushed the integer_division_remainder_used branch from a17a214 to 5afaff7 Compare October 25, 2025 21:53
@github-actions
Copy link

github-actions bot commented Oct 25, 2025 •
edited
Loading

Lintcheck changes for 967d2b1

Lint Added Removed Changed
clippy::integer_division_remainder_used 0 0 1186

This comment will be updated if you push new changes

@ada4a ada4a force-pushed the integer_division_remainder_used branch from 5afaff7 to 5462f25 Compare October 26, 2025 10:09
@ada4a ada4a changed the title refactor(integer_division_remainder_used): move to under operators/ refactor(integer_division_remainder_used): move to under operators Oct 26, 2025
@ada4a ada4a force-pushed the integer_division_remainder_used branch from 5462f25 to ebcba7c Compare October 26, 2025 11:05
@rustbot

This comment has been minimized.

Sign in to view
@ada4a ada4a force-pushed the integer_division_remainder_used branch from ebcba7c to b1bf4f3 Compare October 29, 2025 09:35
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

samueltardieu
samueltardieu requested changes Oct 29, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you squash the second and third commit so that no intermediate commit fails to compile?

r? samueltardieu
@rustbot author

View changes since this review

@rustbot rustbot assigned samueltardieu and unassigned llogiq Oct 29, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@ada4a ada4a force-pushed the integer_division_remainder_used branch from b1bf4f3 to 967d2b1 Compare October 29, 2025 10:02
@ada4a
Copy link
Contributor Author

ada4a commented Oct 29, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 29, 2025
llogiq
llogiq approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

View changes since this review

@samueltardieu samueltardieu added this pull request to the merge queue Oct 29, 2025
Merged via the queue into rust-lang:master with commit d05f74e Oct 29, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

@llogiq llogiq llogiq approved these changes

Assignees

@samueltardieu samueltardieu

Labels

needs-fcp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ada4a @rustbot @samueltardieu @llogiq