Skip to content

Conversation

@ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 23, 2025

Fixes #15741

changelog: [clone_on_ref_ptr]: don't add a & to the receiver if it's a reference

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Sep 23, 2025
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

Lintcheck changes for c831507

Lint Added Removed Changed
clippy::clone_on_ref_ptr 0 0 17

This comment will be updated if you push new changes

@samueltardieu samueltardieu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
@rustbot

This comment has been minimized.

@ada4a ada4a force-pushed the clone_on_ref_ptr-2 branch from d0e7940 to 975a775 Compare October 9, 2025 09:48
@rustbot

This comment has been minimized.

@ada4a ada4a force-pushed the clone_on_ref_ptr-2 branch from 975a775 to c831507 Compare October 11, 2025 14:58
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Oct 11, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clone_on_ref_ptr adds an unnecessary &

3 participants