Skip to content

Refactor ptr_offset_with_cast #15613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor ptr_offset_with_cast #15613

wants to merge 1 commit into from

Conversation

folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Sep 4, 2025 •
edited by rustbot
Loading

based on some comments by @ada4a in #15606. I copied the structure of this lint in that PR, so if that can be cleaned up, this can too.

Putting this lint in /methods is simpler and probably slightly more efficient.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Sep 4, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

No changes for cdca4f4

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work A-lint Area: New lints and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Sep 4, 2025
@folkertdev
Copy link
Contributor Author

Hmm this time rustbot is mistaken, I'm moving a lint here, not adding a new one.

@ada4a
Copy link
Contributor

ada4a commented Sep 4, 2025

Yeah that's a bit annoying..

Here's the incantation to restore the order:
@rustbot label -A-lint -S-blocked S-waiting-on-review
@rustbot note remove Feature-freeze

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed A-lint Area: New lints S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Sep 4, 2025
ada4a
ada4a reviewed Sep 4, 2025
View reviewed changes
@folkertdev folkertdev force-pushed the cleanup-ptr-offset-with-cast branch 2 times, most recently from daea9a2 to 117f43c Compare September 4, 2025 21:49
@folkertdev folkertdev force-pushed the cleanup-ptr-offset-with-cast branch from 117f43c to cdca4f4 Compare September 4, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ada4a ada4a ada4a left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@folkertdev @rustbot @ada4a @Alexendoo