Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 23, 2025

For #11598

changelog: [entry] link to Entry API if can't make a suggestion

@samueltardieu
Copy link
Member

The code currently added in Clippy will be released with 1.91. I think we can allow having unresolved anchors for the nightly and beta release, especially given that the URL is still valid, it will just not position the page at the right place automatically.

Note that if you wait until 1.91 is released, then this fix will only be present in Clippy 1.93, 12 weeks later.

r? samueltardieu

@ada4a
Copy link
Contributor Author

ada4a commented Aug 23, 2025

The code currently added in Clippy will be released with 1.91

Not 1.90? The last entry of the changelog was for 1.89, so I though this PR would end up in 1.90. But I believe you of course

@ada4a ada4a marked this pull request as ready for review August 23, 2025 14:32
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 23, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Aug 23, 2025

The current Clippy sources will be part of the nightly version which is currently 1.91, unless we mark a PR as beta-nominated so that it is also back-ported to the current beta version (1.90), but that is usually reserved for regressions or severe issues.

The ChangeLog is written right before the release of the stable version, but the beta branch (1.90) has been branched from the compiler tree on Aug. 1st.

Everything entering the Clippy repository on or after September 4 will likely land up in 1.92, because:

  • the beta branch for 1.91 will be created from the compiler tree on September 12;
  • the latest scheduled Clippy/compiler sync before this date will happen on September 4.

@samueltardieu samueltardieu added this pull request to the merge queue Aug 23, 2025
Merged via the queue into rust-lang:master with commit 9e1c9eb Aug 23, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 23, 2025
@ada4a ada4a deleted the map-entry branch August 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants